Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply recursion limit api to all tokens #327

Closed
lrlna opened this issue Oct 21, 2022 · 1 comment
Closed

apply recursion limit api to all tokens #327

lrlna opened this issue Oct 21, 2022 · 1 comment
Assignees
@goto-bus-stop
Labels
apollo-parser

Comments

@lrlna
Copy link
Member

lrlna commented Oct 21, 2022 •
edited

To help with securing parser usage in server and/or router environments we should allow limiting the number of tokens that can parsed by the parser. This can expand on the existing recursion limit API we already have, but apply to not only selection sets, but all nodes.

Prior art

GraphQL Java has an implementation limiting number of parsed tokens to help prevent DOS attacks in java graphql servers. And so does graphql-js
@lrlna lrlna changed the title apply recursion limit to number of tokens apply recursion limit api to all tokens Oct 21, 2022
@goto-bus-stop goto-bus-stop self-assigned this Nov 2, 2022
@lrlna
Copy link
Member Author

lrlna commented Jan 17, 2023

done in #347

@lrlna lrlna closed this as completed Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goto-bus-stop goto-bus-stop

Labels
apollo-parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goto-bus-stop @lrlna