Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds homepage and required_ruby_version to gemspec #222

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

davidwessman
Copy link
Contributor

  • The homepage adds a link to Rubygems and makes Dependabot
    work better by including the changelog or commit log in PRs.

- The homepage adds a link to Rubygems and makes Dependabot
  work better by including the changelog or commit log in PRs.
Copy link
Collaborator

@adamstegman adamstegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filling those out!

@adamstegman adamstegman merged commit d496408 into apokalipto:master Apr 20, 2022
@davidwessman davidwessman deleted the gemspec branch April 20, 2022 18:30
@hammady
Copy link

hammady commented Apr 29, 2022

@adamstegman Is there a reason for requiring ruby >= 2.6? I am still on 2.3 and it is working perfectly. I know I am behind, but this may hold many people from using later versions of the gem, not even 2.4 or 2.5!

@adamstegman
Copy link
Collaborator

@hammady yes, see #213! We dropped support for Ruby versions past their end-of-life. Using Ruby versions older than 2.6 carries a security risk, just like using an old version of ruby-saml that we don't support. For me, it also means fewer possibilities for flaky test as we carry a huge matrix of test versions.

I'd highly encourage you to upgrade your Ruby version, if only for security patches. I don't think there are many breaking changes between 2.3 and 2.6.

@hammady
Copy link

hammady commented Apr 29, 2022

@adamstegman Yes, you are right, we are planning the upgrade very soon. I am glad to know there are not much changes required, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants