Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Snapshot version 3.3 #359

Merged
merged 4 commits into from
Feb 19, 2025
Merged

docs: Snapshot version 3.3 #359

merged 4 commits into from
Feb 19, 2025

Conversation

janbuchar
Copy link
Contributor

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@janbuchar janbuchar added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Feb 17, 2025
@janbuchar janbuchar requested a review from B4nan February 17, 2025 17:55
@github-actions github-actions bot added this to the 108th sprint - Tooling team milestone Feb 17, 2025
@B4nan
Copy link
Member

B4nan commented Feb 17, 2025

hmm the broken build is weird, i recall we were dealing with this somewhere already

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@barjin
Copy link
Contributor

barjin commented Feb 19, 2025

It's the broken docs snapshotting in @apify/docusaurus-plugin-typedoc-api. You need to generate the snapshot using an older version of the package. The same thing has happened in Crawlee already - while we know how to circumvent it, I have no idea what causes it (yet) - both versions generate similar-enough JSONs. I can generate the snapshot for you in a sec

@janbuchar
Copy link
Contributor Author

That would be nice, thank you very much @barjin!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…4.2.5`

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…3.0.1`
@barjin
Copy link
Contributor

barjin commented Feb 19, 2025

obrazek

Sorry, something came up - regenerating the typedoc.json with @apify/docusaurus-plugin-typedoc-api@3.0.1 fixes the issue.

My commits also added the recently merged guides (#356 ) to the 3.3 versioned docs, so they show up for users that are not on next. If this is not the desired behaviour, feel free to remove the files (or let me know :))

@janbuchar
Copy link
Contributor Author

No, the guides are a welcome addition 😃 thanks a lot!

@janbuchar janbuchar merged commit 77c9bd6 into master Feb 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants