fix(doctrine): Add a proper exception when a doctrine manager could not be found for a resource class #6995
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
force-pushed
the
doctrine-manager-no-found
branch
from
40eee46 to
457553d
Compare
…ot be found for a resource class
lyrixx
force-pushed
the
doctrine-manager-no-found
branch
from
457553d to
5b47a4e
Compare
lyrixx
changed the title
rvanlaak
reviewed
Mar 14, 2025
| $manager = $this->managerRegistry->getManagerForClass($entityClass); | ||
| if (null === $manager) { | ||
| throw new RuntimeException(\sprintf('No manager found for class "%s". Are you sure it\'s an entity?', $entityClass)); |
There was a problem hiding this comment.
As this exceptional case relates to what the developer wrote; should this not be considered a LogicException instead?
There was a problem hiding this comment.
I don't think so as this may be that the manager isn't properly configured at runtime.
There was a problem hiding this comment.
I agree with @rvanlaak (I put a logic exception in the first place)
I don't see how the manager could not be properly configured... But not a big deal imho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could occur when using a DTO