Laravel: Use Model::qualifyColumn() instead of $table.$column
#6658
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
laravel-qualify
branch
from
b82ee5f to
addc9a0
Compare
|
Awesome thanks @GromNaN ! It's possible that within some filters we're using the same mechanics. With Doctrine we had to duplicate each filter, maybe that with Eloquent we can use the exact same filters? |
I haven't found any other place where the column name is prefixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
Model::qualifyColumn()does exactly the same as the existing code. But for MongoDB, we had to override this method as the column name (field name) cannot be prefixed with the table name (collection name). So we need this method to be used instead of having the logic hard coded.For relations, we use the
getQualifiedForeignKeyNamethat has the same mechanism forBelongsToandHasOneOrManyThrough, but nothing forHasOneOrMany(I don't know why 😞).