Axis scaling enhancements #4284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosco54
force-pushed
the
NiceScale_enhancements
branch
2 times, most recently
from
a6beb92
to
0e5c42a
Compare
rosco54
force-pushed
the
NiceScale_enhancements
branch
from
0e5c42a
to
32b7447
Compare
when zoomed and auto scaling the Y axis. When forceNiceScale = true, set default ticks based on SVG size. Collapsed series handling: 1) The series YAxis map now represents a single axis as well as multiple axes so that collapsed series correctly manage axis visibility there also in both types of charts. 2) Axis hiding now works for mixed charts that include stacked series. 3) Fix a detail that was prematurely hiding axes if series were not available to assign to an axis until loaded via chart.updateSeries. 4) Use the first visible axis to render the grid ticks. Tweaked some sample charts for improved presentation.
when there is scope to do so. 2) When chart is type 'bar', ensure reference to zero is maintained when zoomed and auto scaling the Y axis.
when zoomed and auto scaling the Y axis. When forceNiceScale = true, set default ticks based on SVG size. Collapsed series handling: 1) The series YAxis map now represents a single axis as well as multiple axes so that collapsed series correctly manage axis visibility there also in both types of charts. 2) Axis hiding now works for mixed charts that include stacked series. 3) Fix a detail that was prematurely hiding axes if series were not available to assign to an axis until loaded via chart.updateSeries. 4) Use the first visible axis to render the grid ticks. 5) Fix for: RangeArea Chart: hide all series results in a crash apexcharts#3984 Deselecting all series in a rangeArea graph results in an error apexcharts#4297 Tweaked some sample charts for improved presentation.
rosco54
force-pushed
the
NiceScale_enhancements
branch
from
32b7447
to
d41387d
Compare
7 tasks
junedchhipa
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request
When chart is type 'bar', ensure reference to zero base is maintained when zoomed and auto scaling the Y axis.
When forceNiceScale = true, set default ticks based on SVG size.
Final stage tick culling in Scales.niceScale() is no longer conditional on forceNiceScale = true. This may result in the number of ticks being unexpectedly reduced to just one but is preferable to excessive ticks causing overlapping labels, or a reasonable number of ticks with very unhelpful intervals. For example, setting a max of 365 (prime factors of 5 and 73), with data that ranges from near zero would mean that 5 is the only possible "nice" tick interval producing 73 ticks in total. Because 73 is prime it cannot be reduced in number without introducing labelling that is less useful than none at all.
Collapsed series handling:
The series YAxis map now represents both single axis and multiple axes charts so that collapsed series consistently and correctly determine axis visibility in both kinds of charts.
Axis hiding now works for mixed multi-axis charts that include stacked series. Previously this was excluded for any chart.stacked: true.
Fix a detail that was prematurely hiding axes if series were not available to assign to an axis, e.g. until loaded via chart.updateSeries().
Use the first visible axis to render grid ticks. Previously ticks were always rendered based exclusively on the yaxis[0] regardless of it's hidden status.
Fix for:
RangeArea Chart: hide all series results in a crash RangeArea Chart: hide all series results in a crash #3984
Deselecting all series in a rangeArea graph results in an error Deselecting all series in a rangeArea graph results in an error #4297
Fixes #4263
Fixes #4297
Fixes #3984
Type of change
Checklist: