.github/workflows/codeql-analysis.yml

@@ -56,13 +56,13 @@ jobs:
         cache: 'yarn'
 
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@2d790406f505036ef40ecba973cc774a50395aac # v3.25.13
+      uses: github/codeql-action/init@5cf07d8b700b67e235fbb65cbc84f69c0cf10464 # v3.25.14
       with:
         languages: ${{ matrix.language }}
 
 
     - name: Autobuild
-      uses: github/codeql-action/autobuild@2d790406f505036ef40ecba973cc774a50395aac # v3.25.13
+      uses: github/codeql-action/autobuild@5cf07d8b700b67e235fbb65cbc84f69c0cf10464 # v3.25.14
 
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@2d790406f505036ef40ecba973cc774a50395aac # v3.25.13
+      uses: github/codeql-action/analyze@5cf07d8b700b67e235fbb65cbc84f69c0cf10464 # v3.25.14

cmd/protoc-gen-go-starpc/main.go

@@ -101,10 +101,6 @@ func (s *srpc) ServerImpl(service *protogen.Service) string {
 	return "srpc" + service.GoName + "Server"
 }
 
-func (s *srpc) ServerUnimpl(service *protogen.Service) string {
-	return "SRPC" + service.GoName + "UnimplementedServer"
-}
-
 func (s *srpc) ServerHandler(service *protogen.Service) string {
 	return "SRPC" + service.GoName + "Handler"
 }
@@ -184,14 +180,6 @@ func (s *srpc) generateService(service *protogen.Service) {
 	s.P("}")
 	s.P()
 
-	// Server Unimplemented struct
-	s.P("type ", s.ServerUnimpl(service), " struct {}")
-	s.P()
-	for _, method := range service.Methods {
-		s.generateUnimplementedServerMethod(method)
-	}
-	s.P()
-
 	// Service ID constant
 	serviceID := s.GetServiceID(service)
 	s.P("const ", s.ServerServiceID(service), " = ", strconv.Quote(serviceID))
@@ -446,42 +434,6 @@ func (s *srpc) generateServerSignature(method *protogen.Method) string {
 	return method.GoName + "(" + strings.Join(reqArgs, ", ") + ") " + ret
 }
 
-func (s *srpc) generateUnimplementedServerMethod(method *protogen.Method) {
-	s.P("func (s *", s.ServerUnimpl(method.Parent), ") ", s.generateServerSignature(method), " {")
-	if !method.Desc.IsStreamingServer() {
-		s.P("return nil, ", s.Ident(SRPCPackage, "ErrUnimplemented"))
-	} else {
-		s.P("return ", s.Ident(SRPCPackage, "ErrUnimplemented"))
-	}
-	s.P("}")
-	s.P()
-}
-
-/*
-func (s *srpc) generateServerReceiver(method *protogen.Method) {
-	s.P("func (srv interface{}, ctx context.Context, in1, in2 interface{}) (" + s.Ident(SRPCPackage, "Message") + ", error) {")
-	if !method.Desc.IsStreamingServer() && !method.Desc.IsStreamingClient() {
-		s.P("return srv.(", s.ServerIface(method.Parent), ").")
-	} else {
-		s.P("return nil, srv.(", s.ServerIface(method.Parent), ").")
-	}
-	s.P(method.GoName, "(")
-
-	n := 1
-	if !method.Desc.IsStreamingServer() && !method.Desc.IsStreamingClient() {
-		s.P("ctx,")
-	}
-	if !method.Desc.IsStreamingClient() {
-		s.P("in", n, ".(*", s.InputType(method), "),")
-		n++
-	}
-	if method.Desc.IsStreamingServer() || method.Desc.IsStreamingClient() {
-		s.P("&", s.ServerStreamImpl(method), "{in", n, ".(", s.Ident(SRPCPackage, "Stream"), ")},")
-	}
-	s.P(")")
-}
-*/
-
 func (s *srpc) generateServerMethod(method *protogen.Method) {
 	genSend := method.Desc.IsStreamingServer()
 	genSendAndClose := method.Desc.IsStreamingServer()

package.json

@@ -1,6 +1,6 @@
 {
   "name": "starpc",
-  "version": "0.33.0",
+  "version": "0.33.1",
   "description": "Streaming protobuf RPC service protocol over any two-way channel.",
   "license": "MIT",
   "author": {

tools/go.mod

@@ -39,7 +39,7 @@ require (
 	github.com/alexkohler/prealloc v1.0.0 // indirect
 	github.com/alingse/asasalint v0.0.11 // indirect
 	github.com/aperturerobotics/json-iterator-lite v1.0.0 // indirect
-	github.com/aperturerobotics/util v1.23.11 // indirect
+	github.com/aperturerobotics/util v1.24.0 // indirect
 	github.com/ashanbrown/forbidigo v1.6.0 // indirect
 	github.com/ashanbrown/makezero v1.1.1 // indirect
 	github.com/beorn7/perks v1.0.1 // indirect

tools/go.sum

@@ -44,8 +44,8 @@ github.com/aperturerobotics/protobuf-go v1.33.1-0.20240516052628-4470bc019102 h1
 github.com/aperturerobotics/protobuf-go v1.33.1-0.20240516052628-4470bc019102/go.mod h1:c6P6GXX6sHbq/GpV6MGZEdwhWPcYBgnhAHhKbcUYpos=
 github.com/aperturerobotics/protobuf-go-lite v0.6.5 h1:AuPPcZ7ZaJe9ZYYC4gF7/5/Xbn9Mt9uXyV3+ADWy+Ys=
 github.com/aperturerobotics/protobuf-go-lite v0.6.5/go.mod h1:YTbfnUj3feSULhs8VgepAHFnF3wUc0CPj4jd2axy21I=
-github.com/aperturerobotics/util v1.23.11 h1:nB01x7hbKtZzPyeXsY+OvLBQVM69iQ/OfeT59I32hMQ=
-github.com/aperturerobotics/util v1.23.11/go.mod h1:QiSWcOha1HhCI4f48w6rd3gia9jIMGpfoeJiZMU+jLM=
+github.com/aperturerobotics/util v1.24.0 h1:QIZ2Fr9H+pV9uYs7JHMQPL4+Lz/2BagdrQq09Kru3mQ=
+github.com/aperturerobotics/util v1.24.0/go.mod h1:QiSWcOha1HhCI4f48w6rd3gia9jIMGpfoeJiZMU+jLM=
 github.com/ashanbrown/forbidigo v1.6.0 h1:D3aewfM37Yb3pxHujIPSpTf6oQk9sc9WZi8gerOIVIY=
 github.com/ashanbrown/forbidigo v1.6.0/go.mod h1:Y8j9jy9ZYAEHXdu723cUlraTqbzjKF1MUyfOKL+AjcU=
 github.com/ashanbrown/makezero v1.1.1 h1:iCQ87C0V0vSyO+M9E/FZYbu65auqH0lnsOkf5FcB28s=