Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to chart.js v4.4.1 #1064

Conversation

mihai-peteu
Copy link
Contributor

Pulling in latest version of chart.js as a fix for #1063

@mihai-peteu
Copy link
Contributor Author

Screenshot 2023-12-07 at 6 30 06 AM

Other PRs seem to be failing with the same complaint.
https://github.com/apertureless/vue-chartjs/actions/runs/7111433638

@adamdehaven
Copy link

@apertureless is this repo still maintained?

@apertureless
Copy link
Owner

@mihai-peteu
Can you rebase? The CI should be fixed now.

@mihai-peteu
Copy link
Contributor Author

@apertureless checks passed 🙌

@apertureless apertureless merged commit 34a7e6e into apertureless:main Dec 13, 2023
3 checks passed
@mihai-peteu mihai-peteu deleted the fix/chartjs-4.4.1-dependency-upgrade branch December 13, 2023 21:33
@mihai-peteu
Copy link
Contributor Author

Thanks!

Looks like the website workflow failed.

Does the release workflow need to be run manually? Would love to get this published to npm so we verify this fixes a bug we encountered.

@apertureless
Copy link
Owner

@mihai-peteu
yeah, some pnpm shenanigans with the updated version. Not sure why this happens, as the lockfile should be updated.

The new version is released to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants