Bump up to go 1.23 and clean up Docker images #188
Conversation
|
|
Updated the description |
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| FROM apache/skywalking-eyes:latest |
There was a problem hiding this comment.
How about we push version:latest-go-deps image as well to make it convenient?
There was a problem hiding this comment.
How about we push
version:latest-go-depsimage as well to make it convenient?
I'm not sure whether it'll be convenient, people might be using different go version and it does not make things much better unless we want to push tens of tags for each Go version
|
|
|
Meanwhile, for our own user case, the main repo seems to require Java and Node to do dependency analysis, right? How are we going to support that? |
Simple. We are not using Docker to do that, we use the binary executable right in the system |
|
People who want to use dependencies check with Docker in their projects , they need to build their docker image based on the license-eye docker image, that would be a case by case scenario, some might need to install all of Go 1.19, Java, and npm, some might just need Go 1.23, I'm not going to release an image that contains these various tools. |
Dependencies license check depends on different programming language env and version, it’s unreasonable to include the env in the Docker image by default, this PR cleans the programming language tools from the Docker images to reduce the size from 350+M to ~36M