Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4776]Support tag in litepullconsumer assign mode #4775

Merged

Conversation

lizhiboo
Copy link
Contributor

@lizhiboo lizhiboo commented Aug 4, 2022

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@lizhiboo lizhiboo changed the title Support tag in litepullconsumer assign mode [ISSUE #4776]Support tag in litepullconsumer assign mode Aug 4, 2022
@ShannonDing ShannonDing linked an issue Aug 4, 2022 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Aug 4, 2022

Coverage Status

Coverage decreased (-0.3%) to 49.085% when pulling 488d172 on lizhiboo:support_tag4litepullconsumer_assign into c506036 on apache:develop.

@duhenglucky duhenglucky added this to the 5.0.0 milestone Aug 8, 2022
Copy link
Contributor

@tsunghanjacktsai tsunghanjacktsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lizhiboo ,

Only a small mistake on the variable names and LGTM for the rest. Shall we add some tests for this?

Copy link
Contributor

@caigy caigy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #4775 (0f19acf) into develop (c506036) will decrease coverage by 0.06%.
The diff coverage is 69.23%.

@@              Coverage Diff              @@
##             develop    #4775      +/-   ##
=============================================
- Coverage      45.07%   45.00%   -0.07%     
- Complexity      7617     7627      +10     
=============================================
  Files            976      977       +1     
  Lines          67808    67969     +161     
  Branches        8963     8985      +22     
=============================================
+ Hits           30564    30590      +26     
- Misses         33475    33595     +120     
- Partials        3769     3784      +15     
Impacted Files Coverage Δ
...ent/impl/consumer/DefaultLitePullConsumerImpl.java 70.48% <63.63%> (-0.01%) ⬇️
...ketmq/client/consumer/DefaultLitePullConsumer.java 76.78% <100.00%> (+0.27%) ⬆️
...ntroller/processor/ControllerRequestProcessor.java 26.19% <0.00%> (-20.62%) ⬇️
.../apache/rocketmq/controller/ControllerManager.java 60.86% <0.00%> (-13.58%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-8.96%) ⬇️
...ketmq/client/impl/consumer/PullMessageService.java 49.23% <0.00%> (-3.08%) ⬇️
...ava/org/apache/rocketmq/test/util/VerifyUtils.java 46.26% <0.00%> (-2.99%) ⬇️
.../rocketmq/client/impl/consumer/PullAPIWrapper.java 43.71% <0.00%> (-1.80%) ⬇️
...cketmq/broker/schedule/ScheduleMessageService.java 56.44% <0.00%> (-1.18%) ⬇️
...va/org/apache/rocketmq/common/message/Message.java 52.32% <0.00%> (-0.62%) ⬇️
... and 34 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@ni-ze ni-ze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@duhenglucky duhenglucky merged commit dd87d90 into apache:develop Aug 15, 2022
@lizhiboo lizhiboo deleted the support_tag4litepullconsumer_assign branch August 15, 2022 11:33
RongtongJin pushed a commit to RongtongJin/rocketmq that referenced this pull request Mar 24, 2023
…e#4775)

* support tag for litepullconsumer at assign type

* support tag for litepullconsumer at assign mode

* with namespace

* fix typo

* add test case

* fix

* code style

(cherry picked from commit dd87d90)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tag in litepullconsumer assign mode
9 participants