-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #4776]Support tag in litepullconsumer assign mode #4775
[ISSUE #4776]Support tag in litepullconsumer assign mode #4775
Conversation
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lizhiboo ,
Only a small mistake on the variable names and LGTM for the rest. Shall we add some tests for this?
client/src/main/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumer.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #4775 +/- ##
=============================================
- Coverage 45.07% 45.00% -0.07%
- Complexity 7617 7627 +10
=============================================
Files 976 977 +1
Lines 67808 67969 +161
Branches 8963 8985 +22
=============================================
+ Hits 30564 30590 +26
- Misses 33475 33595 +120
- Partials 3769 3784 +15
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
client/src/main/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumer.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/apache/rocketmq/client/consumer/LitePullConsumer.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
No description provided.