Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1175
Motivation
This fixes the BytesSchema by adding it into the switch-case in the NewBytes constructor, and adds a test showing that it can be used in a producer and consumer. Before the fix, the test fails due to the unrecognised schema in the constructor and the producer and consumer fail to encode the message.
The motivation is that BytesSchema appears to be intended as the default schema (e.g. see here for the Consumer) instead of defining no schema at all, but this code-path is never hit as no Schemas have the NONE type.
I first started looking at this when using a TableView with a topic without a defined or consistent Schema, and I have a work in progress branch for that which will rely on this.
Modifications
Verifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
Documentation