Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PARQUET-2275: Upgrade cyclonedx-maven-plugin to 2.7.6 #1057

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Apr 13, 2023

This PR aims to upgrade cyclonedx-maven-plugin from 2.7.3 to 2.7.6 to bring the latest bug fixes.

Historically, there was some issue reports on the previous versions with the latest Maven.

Now, 2.7.6 is verified in Apache Spark, ORC, Arrow, Avro community as of today.

Jira

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

This PR aims to upgrade `cyclonedx-maven-plugin` from `2.7.3` to `2.7.6` to bring the latest bug fixes.

- https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.6
- https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.5
- https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.7.4

Historically, there was some issue reports on the previous versions with the latest Maven.
- apache/spark#40065
- apache/arrow#35086

Now, 2.7.6 is verified in Apache Spark, ORC, Arrow community as of today.
- [ORC-1407: Upgrade cyclonedx-maven-plugin to 2.7.6](apache/orc#1463)
- [SPARK-42382: Upgrade cyclonedx-maven-plugin to 2.7.6](apache/spark#40726)
- [GH-35086: Upgrade CycloneDX Maven plugin version](apache/arrow#35092)
@dongjoon-hyun
Copy link
Member Author

Could you review this PR when you have some time, @wgtmac ?

@dongjoon-hyun
Copy link
Member Author

Also cc @shangxinli , @ggershinsky too

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dongjoon-hyun

@dongjoon-hyun
Copy link
Member Author

Oh, thank you, @Fokko . Sorry for missing ping.

@Fokko Fokko merged commit 370fb14 into apache:master Apr 13, 2023
7 checks passed
@dongjoon-hyun dongjoon-hyun deleted the PARQUET-2275 branch April 13, 2023 20:48
@Fokko
Copy link
Contributor

Fokko commented Apr 13, 2023

@dongjoon-hyun No problem at all, I wasn't active in the Parquet community lately. Thanks for bumping the version

@wgtmac
Copy link
Member

wgtmac commented Apr 14, 2023

Thanks @dongjoon-hyun and @Fokko !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants