Use the same branch name for ITs on Jenkins #1263
Conversation
slawekjaranowski
requested review from
olamy,
cstamas,
gnodet and
slachiewicz
| checkout([$class: 'GitSCM', | ||
| branches: [[name: ITS_BRANCH]], | ||
| extensions: [[$class: 'CloneOption', depth: 1, noTags: true, shallow: true]], | ||
| userRemoteConfigs: [[url: 'https://github.com/apache/maven-integration-testing.git']]]) |
There was a problem hiding this comment.
We're still using the maven-integration-testing GitHub repo, but it needs to point to the same repository from the PR.
There was a problem hiding this comment.
Didn't we say earlier to use only master for this build?
Or I'm lost?
There was a problem hiding this comment.
Well, then, what's the point of this PR ? I'm lost too...
There was a problem hiding this comment.
Jobs on jenkins are not executed for PR from forked repository.
The goal is minimize a failed build PR on jenkins, when we have change in Maven and connected in ITs.
There was a problem hiding this comment.
We also have a https://github.com/apache/maven-integration-testing/tree/maven-3.8.x branch in ITs - so this branch should be used for testing maven-3.8.x and so on
(cherry picked from commit 882c8dd)
(cherry picked from commit 882c8dd)
We have the same logic on GitHub actions.
When branch with the same name as in repository exist in integration test we should use it.