Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-7729] deprecate questionable IsEmpty/IsNotEmpty methods #136

Merged
merged 4 commits into from Apr 28, 2023
Merged

[MNG-7729] deprecate questionable IsEmpty/IsNotEmpty methods #136

merged 4 commits into from Apr 28, 2023

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Mar 10, 2023

No description provided.

@elharo elharo changed the title [MNG-1201] deprecate questionable utility methods [MNG-1201] deprecate questionable empty/not-empty methods Mar 10, 2023
@elharo elharo requested a review from michael-o March 21, 2023 11:35
michael-o
michael-o requested changes Mar 21, 2023
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue title is wrong and needs to be fixed, same in commits

@elharo elharo changed the title [MNG-1201] deprecate questionable empty/not-empty methods [MNG-1201] deprecate questionable IsEmpty/IsNotEmpty methods Mar 22, 2023
@slachiewicz slachiewicz marked this pull request as draft April 8, 2023 18:39
@elharo elharo changed the title [MNG-1201] deprecate questionable IsEmpty/IsNotEmpty methods [MNG-7729] deprecate questionable IsEmpty/IsNotEmpty methods Apr 28, 2023
@elharo elharo marked this pull request as ready for review April 28, 2023 10:59
elharo
elharo commented Apr 28, 2023
View reviewed changes
Copy link
Contributor Author

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected Maven issue

@elharo elharo merged commit 259b796 into master Apr 28, 2023
12 checks passed
@elharo elharo deleted the MSHARED-1201 branch April 28, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
3 participants
@elharo @michael-o @slawekjaranowski