Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use more modern I/O that does not rely on the system encoding #174

Merged
merged 1 commit into from
Mar 16, 2023
Merged

use more modern I/O that does not rely on the system encoding #174

merged 1 commit into from
Mar 16, 2023

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Mar 16, 2023

No description provided.

@elharo elharo requested a review from michael-o March 16, 2023 11:16
michael-o
michael-o reviewed Mar 16, 2023
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, is there any logical difference?

@elharo
Copy link
Contributor Author

elharo commented Mar 16, 2023

Yes, there is. The current code gets in trouble if pom.xml encoding is incompatible with the system encoding. E.g. one is UTF-16 and one is UTF-8, or one is ISO-8859-1 and one is ISO-8859-1 when non-ASCII characters are used. The new code lets the XML parser detect the encoding so it will determine how the pom.xml is actually encoded instead of assuming it's the same as the system encoding.

@elharo elharo merged commit 0da97a2 into master Mar 16, 2023
@elharo elharo deleted the read branch March 16, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@elharo @michael-o