Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRELEASE-1082] configuration option for using a shallow clone #121

Merged
merged 1 commit into from
May 7, 2022
Merged

[MRELEASE-1082] configuration option for using a shallow clone #121

merged 1 commit into from
May 7, 2022

Conversation

BigMichi1
Copy link
Contributor

@BigMichi1 BigMichi1 commented May 7, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MJAVADOC-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify -Prun-its to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

This patch makes the shallow clone option configurable while still having the default of true. This is useful and needed when running for example a SonarQube analysis during the release process. When the option is true like the current hardcoded default the analyzer complains about missing blame information. If the full history is needed the option can now be set to false to get the full history.

Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that the test source is properly formatted.

@michael-o
Copy link
Member

I will take care of the PR as soon as all comments are resolved.

@asfgit asfgit closed this in 8cc2f45 May 7, 2022
@asfgit asfgit merged commit 8cc2f45 into apache:master May 7, 2022
@BigMichi1 BigMichi1 deleted the shallow_config branch May 7, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants