Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPIR-432] upgrade to parent POM 39 #46

Merged
merged 4 commits into from Apr 8, 2023
Merged

[MPIR-432] upgrade to parent POM 39 #46

merged 4 commits into from Apr 8, 2023

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Mar 26, 2023

No description provided.

@slawekjaranowski
Copy link
Member

Please check for duplicate license headers:

git grep -c "Licensed to the Apache Software Foundation (ASF) under one" | grep -v ":1"

@slawekjaranowski
Copy link
Member

interesting build error on JDK 11

Error:  Step 'palantir-java-format' found problem in 'src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java':
No enum constant javax.lang.model.element.Modifier.SEALED

I have not seen before such ...

@elharo
Copy link
Contributor Author

elharo commented Mar 29, 2023

Fixed the duplicate licenses. The Modifier.SEALED problem remains. I am really not happy with the palantir-java-format. It seems quite buggy and unreliable. I wonder if google-java-format is better? This problem could mean that palantir-java-format is looking at the byte code and getting confused about VM versions.

@elharo
Copy link
Contributor Author

elharo commented Mar 29, 2023

@slawekjaranowski
Copy link
Member

discovered palantir-java-format issue palantir/palantir-java-format#865

@elharo elharo merged commit bb4debd into master Apr 8, 2023
33 checks passed
@elharo elharo deleted the 39 branch April 8, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants