From f7bfa53ee3206497e429742bec2824293d94a4ee Mon Sep 17 00:00:00 2001 From: "Henning P. Schmiedehausen" Date: Wed, 16 Aug 2023 21:48:51 -0700 Subject: [PATCH] Fix empty --patch-module command line entries When using an exclude filter, it is possible that the plugin creates javadoc --patch-module command line options, that do not actually have a value. This changes skips such empty entries. --- .../maven/plugins/javadoc/AbstractJavadocMojo.java | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java b/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java index a2ba79fd..18fea1cc 100644 --- a/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java +++ b/src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java @@ -4594,12 +4594,14 @@ private void addJavadocOptions( } for (Entry> entry : patchModules.entrySet()) { - addArgIfNotEmpty( - arguments, - "--patch-module", - entry.getKey() + '=' + JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())), - false, - false); + if (!entry.getValue().isEmpty()) { + addArgIfNotEmpty( + arguments, + "--patch-module", + entry.getKey() + '=' + JavadocUtil.quotedPathArgument(getSourcePath(entry.getValue())), + false, + false); + } } if (doclet != null && !doclet.isEmpty()) {