Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHARED-1330] Always overwrite files #97

Merged
merged 5 commits into from Mar 2, 2024
Merged

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Feb 26, 2024

Make sure the files are made writable before copying them. The attributes are always restored after the copy.

@gnodet gnodet requested a review from cstamas February 26, 2024 20:18
@gnodet gnodet added this to the 3.3.2 milestone Feb 26, 2024
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need to set the execute bit?

@gnodet
Copy link
Contributor Author

gnodet commented Feb 26, 2024

why do you need to set the execute bit?

We don't, we just need it to be readable and writable, I'll remove that line.

@gnodet
Copy link
Contributor Author

gnodet commented Feb 26, 2024

why do you need to set the execute bit?

Fixed

@gnodet gnodet merged commit 442b63e into apache:master Mar 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants