Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support converting '.NET TP Worker' to the numeric thread ID on .NET 8+ #103

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

erikmav
Copy link
Contributor

@erikmav erikmav commented Jan 12, 2024

No description provided.

@erikmav erikmav force-pushed the dev/erikmav/net8ThreadPoolWorker branch from dff597c to ab74a0a Compare January 12, 2024 18:41
@michal-ciechan
Copy link

Any chance this can be merged, so that we don't have to fork.

@FreeAndNil
Copy link
Contributor

@fluffynuts can you take a look?

@vy
Copy link
Member

vy commented Jan 31, 2024

@erikmav, @michal-ciechan, @FreeAndNil, log4net is in great need of maintainers. @fluffynuts, the only active maintainer, and whom I believe will soon take care of this PR, can definitely use some help. Would any of you be willing to step up as a maintainer? If so, could you share this in an email to dev@, please? I cannot speak for the rest of the PMC, but IMO, we can grant a volunteer the committer rights. Equipped with that, they can merge PRs, commit changes, etc. The release cannot be done by committers; there PMC members are needed for reviewing and performing the release anyway.

@fluffynuts fluffynuts merged commit 765567a into apache:master Jan 31, 2024
@fluffynuts
Copy link
Contributor

@michal-ciechan merged - I can't make any guarantees of a release date though, but perhaps after I've finished some other opensource PR I've been working on in the little spare time I have for the last 3 weeks (:

@poormonfared
Copy link

Hi, when will this fix get released?! It's a really hot fix.
We already had similar issues twice. 1-wrong thread name in updating to.net 6; 2-wrong process name after migrating to.net 7.
Why should we see this again? It would be nice if we carefully tracked our previous issues.

@fluffynuts
Copy link
Contributor

Considering my constrained time, and even though @FreeAndNil recently stepped up to be a maintainer, I don't see any time really soon. You can, in the meantime, check out the repo, build, and distribute a dll with your app if it's that important. It's not convenient, I'll admit, but if it's urgent, it's an option.

@poormonfared
Copy link

@fluffynuts actually, if we replaced ThreadName with our customized property field, then we wouldn't need to replace the library anymore.

@FreeAndNil FreeAndNil added this to the 2.0.16 milestone Mar 5, 2024
@FreeAndNil
Copy link
Contributor

@erikmav, @michal-ciechan, @poormonfared we've released https://www.nuget.org/packages/log4net/2.0.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants