LOG4J2-673 – plugin preloading fails in shaded jar files #4
+192
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for plugin preloading through the standard javax.annotation.processing tool was adding in LOG4J2-595 But the plugin processor always creates and stores the processed "Plugin" annotated classes into the same "Log4j2Plugins.dat" file. This works fine when the classpath consists of individual jar files, but fails when shaded jar files are used. Add a ResourceTransformer that can be used in conjunction with the maven-shaded-plugin to merge multiple Log4j2Plugins.dat into one.
|
I'm thinking of working on a new plugin cache file format that would simplify this whole problem. We're discussing this on the dev mailing list currently, but it's also mentioned in LOG4J2-798. |
|
Shit, I closed this by accident. Meant to close #5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for plugin preloading through the standard javax.annotation.processing tool was adding in LOG4J2-595
But the plugin processor always creates and stores the processed "Plugin" annotated classes into the same "Log4j2Plugins.dat" file. This works fine when the classpath consists of individual jar files, but fails when shaded jar files are used.
Add a ResourceTransformer that can be used in conjunction with the maven-shaded-plugin to merge multiple Log4j2Plugins.dat into one.