The core.Logger#setLevel method should work like #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppkarwasz
reviewed
Feb 13, 2024
| @@ -542,6 +542,7 @@ | |||
| <plugin> | |||
| <groupId>org.apache.rat</groupId> | |||
| <artifactId>apache-rat-plugin</artifactId> | |||
| <version>0.16.1</version> | |||
There was a problem hiding this comment.
We should bump this in logging-parent if necessary or even better in the ASF parent: apache/maven-apache-parent#193
|
BTW: you should also add a file in |
vy
added
bug
garydgregory
force-pushed
the
2.x-issue-2281
branch
from
cb1f19f
to
5bf9bbd
Compare
|
I added tests but they fail. I can't tell if the issue is in main or the test itself... See |
Configurator#setLevel apache#2281
garydgregory
force-pushed
the
2.x-issue-2281
branch
from
5bf9bbd
to
99c4e2f
Compare
|
TY @ppkarwasz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core.Logger#setLevel method should work like Configurator#setLevel #2281
@ppkarwasz
I'm not sure how to really test this from our 1.2 module but I did install a snapshot locally and tested it with my Apache Commons Logging branch here https://github.com/garydgregory/commons-logging/tree/log4j1-log42-api
The POM change to apache-rat-plugin was required for
mvn clean verifyto pass locally.