Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS8] Branch main overhaul #3 #2163

Closed
ppkarwasz opened this issue Jan 4, 2024 · 2 comments
Closed

[MS8] Branch main overhaul #3 #2163

ppkarwasz opened this issue Jan 4, 2024 · 2 comments
Assignees
Labels
STF-Milestones Milestones funded by the Sovereign Tech Fund
Milestone

Comments

@ppkarwasz
Copy link
Contributor

ppkarwasz commented Jan 4, 2024

This story aims to overhaul main (targeting Log4j version 3.0.0) branch as a follow up of #1969 and #2016.

Removal of deprecated features

main, since it is forked from 2.x, contains several features and modules that are suitable to be dropped. Since this is a backward incompatible change, we cannot implement this for 2.x. main, targeting 3.0.0, i.e., a new major version release, is a good opportunity for this. Following changes are mostly related with that.

Split functionality to dedicated modules

2.x used to combine several features in one module: log4j-core. This imposes, next to a greater surface for potential vulnerabilities, several disadvantages for those who only need a subset of these offered features. Here we try to improve this experience by moving certain functionalities to their own dedicated modules.

Port changes from 2.x

main was forked ~6 years ago from 2.x. In the meantime, thousands of improvements were introduced to 2.x and sadly a majority of these were not ported to main. Put another way, main contains several issues that were already fixed in 2.x. Below shared items are related with porting such changes from 2.x to main.

Miscellaneous improvements

In accordance with Boy Scout Rule, things we have improved along the way:

@ppkarwasz ppkarwasz added the STF-Milestones Milestones funded by the Sovereign Tech Fund label Jan 4, 2024
@ppkarwasz ppkarwasz assigned ppkarwasz and vy and unassigned ppkarwasz Jan 4, 2024
@ppkarwasz ppkarwasz added this to the 3.0.0 milestone Jan 4, 2024
vy added a commit that referenced this issue Jan 10, 2024
vy added a commit that referenced this issue Jan 10, 2024
vy added a commit that referenced this issue Jan 10, 2024
vy added a commit that referenced this issue Jan 10, 2024
vy added a commit that referenced this issue Jan 10, 2024
vy added a commit that referenced this issue Jan 10, 2024
vy added a commit that referenced this issue Jan 10, 2024
vy added a commit that referenced this issue Jan 10, 2024
vy added a commit that referenced this issue Jan 10, 2024
ppkarwasz added a commit to ppkarwasz/logging-log4j2 that referenced this issue Jan 12, 2024
This ports the changes to the `log4j-1.2-api` module that never made it
to `main`.

Part of apache#2163.
ppkarwasz added a commit to ppkarwasz/logging-log4j2 that referenced this issue Jan 15, 2024
This ports the changes to the `log4j-1.2-api` module that never made it
to `main`.

Part of apache#2163.
ppkarwasz added a commit to ppkarwasz/logging-log4j2 that referenced this issue Jan 15, 2024
This ports the changes to the `log4j-1.2-api` module that never made it
to `main`.

Part of apache#2163.
vy added a commit that referenced this issue Jan 15, 2024
vy added a commit that referenced this issue Jan 15, 2024
@ppkarwasz
Copy link
Contributor Author

While working on #2227 I checked that no regressions are present in the o.a.l.l.core.async package in the main branch.

@grobmeier
Copy link
Member

Checked and considered complete.

@ppkarwasz ppkarwasz modified the milestones: 3.0.0, 3.0.0-beta2 Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
STF-Milestones Milestones funded by the Sovereign Tech Fund
Projects
None yet
Development

No branches or pull requests

3 participants