Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the key encoding version #2292

Open
1 of 2 tasks
PragmaTwice opened this issue May 5, 2024 · 3 comments
Open
1 of 2 tasks

Introduce the key encoding version #2292

PragmaTwice opened this issue May 5, 2024 · 3 comments
Labels
enhancement type enhancement help wanted Good for newcomers

Comments

@PragmaTwice
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

The current key encoding has some historical legacy issues, and we need to adjust it through some means while ensuring compatibility.

To do this, first we can persist a key encoding version in storage and read it during loading.

Solution

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@PragmaTwice PragmaTwice added enhancement type enhancement help wanted Good for newcomers labels May 5, 2024
@VasuDevrani
Copy link
Contributor

VasuDevrani commented May 15, 2024

I went through the codebase, can you confirm if i got it right?

  • the key encoding logic (encoding and decoding) is implemented in the InternalKey class
  • can be fixed by introducing a new variable for encoding version, a function to read it from storage during loading process, update InternalKey class to handle different versions

@VasuDevrani
Copy link
Contributor

/assign

@PragmaTwice
Copy link
Member Author

I went through the codebase, can you confirm if i got it right?

  • the key encoding logic (encoding and decoding) is implemented in the InternalKey class
  • can be fixed by introducing a new variable for encoding version, a function to read it from storage during loading process, update InternalKey class to handle different versions

Yeah you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement help wanted Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants