Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CompactionChecker for "search" CF #2263

Open
1 of 2 tasks
mapleFU opened this issue Apr 22, 2024 · 1 comment
Open
1 of 2 tasks

Enable CompactionChecker for "search" CF #2263

mapleFU opened this issue Apr 22, 2024 · 1 comment
Labels
enhancement type enhancement

Comments

@mapleFU
Copy link
Member

mapleFU commented Apr 22, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Motivation

std::vector<std::string> cf_names = {engine::kMetadataColumnFamilyName, engine::kSubkeyColumnFamilyName,
engine::kZSetScoreColumnFamilyName, engine::kStreamColumnFamilyName};

Should we enable compaction checker in this checking?

Solution

          std::vector<std::string> cf_names = {engine::kMetadataColumnFamilyName, engine::kSubkeyColumnFamilyName,
                                               engine::kZSetScoreColumnFamilyName, engine::kStreamColumnFamilyName};
          for (const auto &cf_name : cf_names) {
            compaction_checker.PickCompactionFiles(cf_name);
          }

Add type in this list

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@mapleFU mapleFU added the enhancement type enhancement label Apr 22, 2024
@mapleFU
Copy link
Member Author

mapleFU commented Apr 22, 2024

@PragmaTwice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type enhancement
Projects
None yet
Development

No branches or pull requests

1 participant