Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bindings/python): expose presign api #2950

Merged
merged 7 commits into from Aug 29, 2023
Merged

feat(bindings/python): expose presign api #2950

merged 7 commits into from Aug 29, 2023

Conversation

silver-ymz
Copy link
Member

Close #2921

@silver-ymz
feat(bindings/python): expose presign api
2230388 
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
@silver-ymz silver-ymz requested a review from Xuanwo August 28, 2023 04:24
@silver-ymz silver-ymz marked this pull request as draft August 28, 2023 04:33
@silver-ymz
add test for presign
f14ff6e 
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
@silver-ymz
fix HeaderMap to return error for invalid value
150f54d 
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
@silver-ymz silver-ymz marked this pull request as ready for review August 28, 2023 05:13
@silver-ymz
update headers function signature && rename presign test
ec8e930 
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
@silver-ymz
typo
47f200b 
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
@silver-ymz
update test for presign
c154c21 
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
@Xuanwo
Copy link
Member

Xuanwo commented Aug 28, 2023

I mostly agree, but I still have some hesitation about the presign's API.

@silver-ymz
Copy link
Member Author

In 47f200b ci, Bindings Python CI / test (pull_request) failed.

Fatal Python error: PyGILState_Release: thread state 0x7f97c4002610 must be current when releasing
Python runtime state: finalizing (tstate=0x00007f97cbbb0278)

Thread 0x00007f97cb320c40 (most recent call first):
  <no Python frame>
/home/runner/work/_temp/08e64cf5-ea8f-4e6f-861a-40ba4a202912.sh: line 1:  5178 Aborted                 (core dumped) python -m behave tests

I think this shouldn't happen. Is there anything wrong?

@Xuanwo
Copy link
Member

Xuanwo commented Aug 28, 2023 •
edited

PyGILState_Release: thread state 0x7f97c4002610 must be current when releasing

The root cause has not been identified yet, unfortunately. You can explore further if you are interested in this issue. For more details, please refer to: #1723.

@silver-ymz
make clear for expire second
98ebd77 
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Xuanwo
Xuanwo approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 8169efc into main Aug 29, 2023
24 checks passed
@Xuanwo Xuanwo deleted the python-presign branch August 29, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messense messense messense left review comments

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature request: expose presign API in python binding
3 participants
@silver-ymz @Xuanwo @messense