Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Implement Exact Buf Writer #2917

Merged
merged 10 commits into from Aug 24, 2023
Merged

feat(core): Implement Exact Buf Writer #2917

merged 10 commits into from Aug 24, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Aug 23, 2023

Some services requires to write to storage with same langth. ExactBufWriter will make sure that flush storage with the exact the same size.

This PR just add this writer, and no service using it yet.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from PsiACE as a code owner August 23, 2023 15:19
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@oowl
Copy link
Member

oowl commented Aug 23, 2023

Some services requires to write to storage with same langth. ExactBufWriter will make sure that flush storage with the exact the same size.

Just curious, Which service has this requirement?

@suyanhanx
Copy link
Member

#2904 @oowl

@Xuanwo Xuanwo merged commit cbac9b8 into main Aug 24, 2023
79 checks passed
@Xuanwo Xuanwo deleted the exact-buf-write branch August 24, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants