Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove operator range_read and range_reader API #2898

Merged
merged 4 commits into from Aug 22, 2023
Merged

feat: remove operator range_read and range_reader API #2898

merged 4 commits into from Aug 22, 2023

Conversation

oowl
Copy link
Member

@oowl oowl commented Aug 21, 2023 •
edited by Xuanwo

part of #2885

@oowl oowl mentioned this pull request Aug 20, 2023
Closed
2 tasks
@suyanhanx suyanhanx changed the title feat: remove operator rangge_read and range_reader API feat: remove operator range_read and range_reader API Aug 21, 2023
@oowl oowl force-pushed the feat/merge_range_read branch 2 times, most recently from f1e4ea3 to 3a2a361 Compare August 22, 2023 04:13
@oowl oowl requested a review from Xuanwo August 22, 2023 04:44
Xuanwo
Xuanwo approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo
Copy link
Member

Xuanwo commented Aug 22, 2023

I changed the close to part of since our blocking operator should also be updated.

@Xuanwo Xuanwo merged commit ba7e116 into main Aug 22, 2023
80 of 81 checks passed
@Xuanwo Xuanwo deleted the feat/merge_range_read branch August 22, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oowl @Xuanwo