Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(layers/logging): Allow users to control print backtrace or not #2872

Merged
merged 3 commits into from Aug 16, 2023
Merged

feat(layers/logging): Allow users to control print backtrace or not #2872

merged 3 commits into from Aug 16, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Aug 16, 2023

No description provided.

@Xuanwo
Don't print backtrace during retry
7b869b3 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Enable backtrace output for testing
40f07a5 
Signed-off-by: Xuanwo <github@xuanwo.io>
suyanhanx
suyanhanx approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Please add this into the v0.40's changelog.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 16, 2023 •
edited

Please add this into the v0.40's changelog.

It's not a breaking change, I will add this in feature's changelog instead.

@Xuanwo Xuanwo merged commit cfd4da4 into main Aug 16, 2023
86 of 87 checks passed
@Xuanwo Xuanwo deleted the control-logging branch August 16, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xuanwo @suyanhanx