Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/moka, services/mini-moka): Add scan support #2850

Merged
merged 1 commit into from Aug 11, 2023
Merged

feat(services/moka, services/mini-moka): Add scan support #2850

merged 1 commit into from Aug 11, 2023

Conversation

JLerxky
Copy link
Contributor

@JLerxky JLerxky commented Aug 11, 2023 •
edited by Xuanwo

Fix #2849

@JLerxky JLerxky requested a review from Xuanwo as a code owner August 11, 2023 08:28
Xuanwo
Xuanwo approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit d380275 into apache:main Aug 11, 2023
24 of 25 checks passed
@JLerxky JLerxky deleted the add_scan_for_moka branch August 11, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Implement scan for moka and mini-moka
2 participants
@JLerxky @Xuanwo