Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ci for php binding #2830

Merged
merged 8 commits into from Aug 9, 2023
Merged

feat: ci for php binding #2830

merged 8 commits into from Aug 9, 2023

Conversation

godruoyi
Copy link
Contributor

@godruoyi godruoyi commented Aug 9, 2023

No description provided.

@godruoyi
Copy link
Contributor Author

godruoyi commented Aug 9, 2023

The command cargo php install --yes will copy the opendal extension to the extension directory of PHP. However, if we do not use sudo, it will fail due to permission issues. but cargo is not installed for the sudo user so we can't use sudo now, we are trying other solutions. If you have any better suggestions, please let me know.

https://github.com/apache/incubator-opendal/actions/runs/5806993239/job/15741005484

updates:

  • I will attempt to compile and copy the extension manually, so we no longer need cargo-php soon.

@oowl
Copy link
Member

oowl commented Aug 9, 2023

Maybe you can try sudo -E cargo php install --yes

-E, --preserve-env
             Indicates to the security policy that the user wishes to preserve their
             existing environment variables.  The security policy may return an error
             if the user does not have permission to preserve the environment.

@Xuanwo
Copy link
Member

Xuanwo commented Aug 9, 2023

I will attempt to compile and copy the extension manually, so we no longer need cargo-php soon.

Good!

@godruoyi godruoyi marked this pull request as ready for review August 9, 2023 13:59
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@Xuanwo Xuanwo merged commit 57e6b18 into apache:main Aug 9, 2023
4 checks passed
@godruoyi godruoyi deleted the feat/php-binding-ci branch August 10, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants