feat: Add postgresql support for OpenDAL #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It sounds a bit crazy, but why not :) |
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
|
It's a really really crazy idea! Next, Maybe we need to build OpenDAL on SQLite! |
Ok, let's expand OpenDAL to more open areas! |
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add postgresql support for OpenDAL.
OHHHHHHH, why? It doesn't make sense to add SQL support in OpenDAL!
You are right. OpenDAL is designed for accessing unstructured data like local fs and s3. And database like postgresql is not good for such use cases. But it doesn't mean we can't do this.
We can store some small (for example, 4KiB) data in database in quick and easy way! We don't need to worry about mysql, pg, clickhouse, xxxdb anymore: use opendal and write data.
Maybe, I'm not convinced and still believe it's useless.
That's Ok. OpenDAL's design makes sure that adding a new service like pg won't affect your existing features at all. Postgresql will under
services-postgresqlfeature and only users who enable this feature will need those code.So, What's the performance?
We don't know about it so far. This PR just a start, we will try to do some bench to have a general idea about it's perf.
What's next?
I will add integration test to make this service works. And than we can try to add MySQL, SurrealDB and other dbs.
My current interest is to add databend support so that I can run databend on databend (aha, this is really useless, but funny)!