Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings/haskell): enhance original OpMonad to support custom IO monad #2789

Merged
merged 4 commits into from Aug 6, 2023

Conversation

silver-ymz
Copy link
Member

Update:

  • rename OpMonad to OperatorT, and add support for custom IO monad
  • add some documents and examples
  • simplify config file

OperatorT is a monad transformer which keeps Operator in its context. I think previous name OpMonad is a little confused. And OperatorT is more suitable for community naming rules, since there are some popular monad transformers named to ReaderT, ExceptT, etc. So I rename OpMonad to OperatorT.

…IO monad

Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo
Copy link
Member

Xuanwo commented Aug 6, 2023

btw, why haskell's building is much slower than before?

Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
@silver-ymz silver-ymz requested a review from PsiACE as a code owner August 6, 2023 11:29
@Xuanwo Xuanwo merged commit 900e476 into main Aug 6, 2023
20 checks passed
@Xuanwo Xuanwo deleted the feat/haskell-operator-transformer branch August 6, 2023 11:58
@silver-ymz
Copy link
Member Author

btw, why haskell's building is much slower than before?

Haskell binding has lots of dependencies now, and ghc compiler is quiet slow. Could we use cache to speed up CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants