Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(binding/php): Add basic io #2782

Merged
merged 10 commits into from Aug 8, 2023
Merged

feat(binding/php): Add basic io #2782

merged 10 commits into from Aug 8, 2023

Conversation

godruoyi
Copy link
Contributor

@godruoyi godruoyi commented Aug 4, 2023

This is part of #2716. In this PR, we have completed the basic IO functionality and will continue to add other features such as CI/iterators/documentation.

Xuanwo
Xuanwo reviewed Aug 4, 2023
View reviewed changes
bindings/php/src/lib.rs Show resolved Hide resolved
bindings/php/src/lib.rs Outdated Show resolved Hide resolved
bindings/php/src/lib.rs Show resolved Hide resolved
bindings/php/src/lib.rs Outdated Show resolved Hide resolved
bindings/php/src/lib.rs Outdated Show resolved Hide resolved
@Xuanwo Xuanwo changed the title feat(binding/php) basic io feat(binding/php): Add basic io Aug 4, 2023
Xuanwo
Xuanwo reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. Mostly LGTM, only have some questions.

bindings/php/opendal-php.stubs.php Show resolved Hide resolved
bindings/php/opendal-php.stubs.php Show resolved Hide resolved
bindings/php/opendal-php.stubs.php Show resolved Hide resolved
bindings/php/opendal-php.stubs.php Outdated Show resolved Hide resolved
bindings/php/src/lib.rs Show resolved Hide resolved
bindings/php/tests/Feature/BasicIOTest.php Show resolved Hide resolved
@godruoyi godruoyi mentioned this pull request Aug 8, 2023
Open
3 tasks
@godruoyi godruoyi mentioned this pull request Aug 8, 2023
Closed
Xuanwo
Xuanwo approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 321a2f1 into apache:main Aug 8, 2023
19 checks passed
@godruoyi godruoyi deleted the feat/php-binding-basic-io branch August 8, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@godruoyi @Xuanwo