Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add async backtrace layer #2765

Merged
merged 4 commits into from Aug 3, 2023
Merged

feat: add async backtrace layer #2765

merged 4 commits into from Aug 3, 2023

Conversation

dqhl76
Copy link
Member

@dqhl76 dqhl76 commented Aug 3, 2023 •
edited

close #2617

@dqhl76
feat: add async backtrace layer
48a0691 
Signed-off-by: dqhl76 <dqhl76@gmail.com>
@dqhl76
docs: add document for async backtrace layer
16ebac8 
Signed-off-by: dqhl76 <dqhl76@gmail.com>
@dqhl76
fix: add cargo lock change
c475647 
Signed-off-by: dqhl76 <dqhl76@gmail.com>
oowl
oowl requested changes Aug 3, 2023
View reviewed changes
Copy link
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But need to fix one lint problems.

core/Cargo.toml Outdated Show resolved Hide resolved
@dqhl76 @oowl
fix: format layout
25474db 
Co-authored-by: oowl <ouyangjun1999@gmail.com>
@oowl
Copy link
Member

oowl commented Aug 3, 2023

And about #2617 (comment), Any progress in there? Can you give us how to reproduce these issues here?

@dqhl76
Copy link
Member Author

dqhl76 commented Aug 3, 2023

And about #2617 (comment), Any progress in there? Can you give us how to reproduce these issues here?

It is very strange. It pass cargo check cargo build but my IDE still gave me a error tip:

Not all trait items implemented, missing: `read`, `write`, `append`, `list` [E0046]

maybe rust-analyzer's problem?

@oowl
Copy link
Member

oowl commented Aug 3, 2023

And about #2617 (comment), Any progress in there? Can you give us how to reproduce these issues here?

It is very strange. It pass cargo check cargo build but my IDE still gave me a error tip:

Not all trait items implemented, missing: `read`, `write`, `append`, `list` [E0046]

maybe rust-analyzer's problem?

It's no problem in my IDE (vscode + rust-analyzer).

oowl
oowl approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oowl
Copy link
Member

oowl commented Aug 3, 2023

Hi @Xuanwo, Can you take a look at this PR?

@Xuanwo Xuanwo mentioned this pull request Aug 3, 2023
Open
Xuanwo
Xuanwo approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit dceea19 into apache:main Aug 3, 2023
85 checks passed
@dqhl76
Copy link
Member Author

dqhl76 commented Aug 3, 2023

Thanks for reviewing!

@dqhl76 dqhl76 deleted the async-backtrace branch August 3, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@oowl oowl oowl approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add AsyncBacktraceLayer to allow users dump this execution tree at runtime
3 participants
@dqhl76 @oowl @Xuanwo