New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bindings/haskell): support logging layer #2705
Conversation
I believe that the first layer to be implemented should be |
…xLayer Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
c06633d
to
690bc87
Compare
I have already completed exposing logging layer. Because haskell doesn't have unified logging framework, I design the API to pass a callback function from Haskell for rust to pass log information.
I make some mistakes about |
I'd like to schedule a brief meeting with you regarding this PR, if you're available. Our goal is to address any blockers that may be hindering progress. |
8951066
to
e96be0b
Compare
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
e96be0b
to
c604f0c
Compare
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Original code format was modified by myself. Now I change it to ormolu default format. I think it's better for others to make contribution. |
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
I integrate co-log library into logging layer. Now users only need to fill For the simple case of output to stdout, they can use |
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
It seems that co-log only supports ghc-9.2. For higher ghc version, we need to wait co-log/co-log#251 |
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
Signed-off-by: silver-ymz <yinmingzhuo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No better ideas, let's move!
Update:
lib.rs
Because haskell doesn't have unified logging framework, I design the API to pass a callback function from Haskell for rust to pass log information.