test(blocking): tests for blocking append #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Sep 8, 2023
|
For the service fs, doing append will go wrong definitely here if we enable atomic_write. It's better to set a new test job for atomic_write. |
Negative, this is a violation of our VISION. We can't add different test for services with different configure values.
It's a bug. We should fix it from fs internal. |
Xuanwo
reviewed
Sep 8, 2023
Xuanwo
reviewed
Sep 10, 2023
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
suyanhanx
force-pushed
the
empty-file-test
branch
from
f11f868
to
2d59e9a
Compare
Xuanwo
reviewed
Sep 18, 2023
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
… into empty-file-test
Xuanwo
reviewed
Sep 18, 2023
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Xuanwo
reviewed
Sep 18, 2023
suyanhanx
force-pushed
the
empty-file-test
branch
from
b1272c3
to
25b8a8a
Compare
Young-Flash
pushed a commit
to Young-Flash/opendal
that referenced
this pull request
Sep 19, 2023
* test for blocking append & fix fs Signed-off-by: suyanhanx <suyanhanx@gmail.com> * move path check to path build block Signed-off-by: suyanhanx <suyanhanx@gmail.com> * path check when append enabled only Signed-off-by: suyanhanx <suyanhanx@gmail.com> --------- Signed-off-by: suyanhanx <suyanhanx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although there are not many services having native implementations of blocking_write now, we still need to cover them.
(because append has been merged into write).