Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the main image on the spec. #9843

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

bitsondatadev
Copy link
Collaborator

@bitsondatadev bitsondatadev commented Mar 1, 2024

Fix the main image on the spec.

@github-actions github-actions bot added the Specification Issues that may introduce spec changes. label Mar 1, 2024
@bitsondatadev bitsondatadev requested a review from nastra March 1, 2024 06:12
@bitsondatadev bitsondatadev self-assigned this Mar 1, 2024
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javadoc links aren't working, but the other changes look good

@bitsondatadev
Copy link
Collaborator Author

lol I forgot this is from another directory higher than the docs...I know relative links are better in the long run but ugh they're a pain to debug in the beginning.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@bitsondatadev bitsondatadev requested review from rdblue and nastra March 2, 2024 20:35
@bitsondatadev bitsondatadev changed the title Move format docs to mkdocs from hugo and fix links Fix the main image on the spec. Mar 2, 2024
@amogh-jahagirdar
Copy link
Contributor

Discussed with @bitsondatadev right now we're aiming to get the image fixed first, that works for me locally.

@amogh-jahagirdar amogh-jahagirdar merged commit f9ad8f3 into apache:main Mar 2, 2024
2 checks passed
devangjhabakh pushed a commit to cdouglas/iceberg that referenced this pull request Apr 22, 2024
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Specification Issues that may introduce spec changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants