Core: FileIO Reflection Error Message is Misleading #9840
Merged
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current error message always says FileIO "missing no-arg constructor: " whenever a NoSuchMethod is thrown but we've seen several instances of the underlying exception being completely unrelated to the existence of a no arg constructor and actually a NSM exception being thrown from a dependent class.
The biggest culprit of this is S3FileIO, for example if you have a bad AWS SDK you can see something like
#7396
While our error message says it's missing a no-arg constructor the ACTUAL issue is that the AWS SDK is not on the classpath.
To fix this I've changed the error message to mirror the one for the LoadCatalog code which doesn't insert a statement about it missing a no-arg constructor. I think we have similar issues with the class cast error message but I haven't seen that been wrong in the wild yet.