Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPCLIENT-2314: Handle gracefully a failure of DnsResolver to return a list of resolved addresses #533

Merged
merged 5 commits into from
Jan 7, 2024

Conversation

phax
Copy link
Contributor

@phax phax commented Jan 7, 2024

Make sure an UnknownHostException is thrown, even if a custom DnsResolver implementation is used.
Fixes the issue of HTTPCLIENT-2314

Copy link
Member

@ok2c ok2c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phax

  1. Please remove my changes from your change-set. If the check is moved to the connection operator it not necessary or even useless in the SystemDefaultDnsResolver.
  2. Please make symmetric changes to the MultihomeIOSessionRequester

@phax
Copy link
Contributor Author

phax commented Jan 7, 2024

@ok2c Thanks for the review. Done

@ok2c ok2c changed the title 5.3.x - HTTPCLIENT-2314 HTTPCLIENT-2314: Handle gracefully a failure of DnsResolver to return a list of resolved addresses Jan 7, 2024
@ok2c ok2c merged commit 1650831 into apache:5.3.x Jan 7, 2024
7 checks passed
ok2c pushed a commit that referenced this pull request Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants