feature(SSLConnectionSocketFactory): Pass HttpContext to prepareSocket method

[alturkovic]

Some implementations might depend on a variable present in the HttpContext which is available in most other methods.

[ok2c]

@alturkovic The change-set breaks backward compatibility with 5.0 APIs.

By the way, one may be better off writing a custom SSLConnectionSocketFactory instead of trying to make the default one work in all specific cases.

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  46.847 s
[INFO] Finished at: 2023-01-04T13:46:47Z
[INFO] ------------------------------------------------------------------------
Error:  Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.16.0:cmp (default) on project httpclient5: There is at least one incompatibility: org.apache.hc.client5.http.ssl.SSLConnectionSocketFactory.prepareSocket(javax.net.ssl.SSLSocket):METHOD_REMOVED -> [Help 1]

[alturkovic]

@ok2c Oops, added the method back. I understand, I just thought that having HttpContext available by default made sense.

[ok2c]

@alturkovic Please deprecate the old method in favor of the new one.

[ok2c]

@alturkovic Great. But please do it nicely and suppress deprecation warnings in the new method.

[alturkovic]

Sorry, I do not know what you mean by that, I took a look how other methods are deprecated (i.e.: org.apache.hc.client5.http.ssl.ClientTlsStrategyBuilder#setTlsDetailsFactory) and I do not see any suppressions? Would you mind explaining a bit more what needs to be done?

[ok2c]

@alturkovic Please add @SuppressWarnings("deprecation") annotation to the new method.