Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): allow nullable value for OptionDataValue #19111

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

avin-kavish
Copy link
Contributor

@avin-kavish avin-kavish commented Sep 13, 2023

FYI, as per the doc null and undefined values are accepted in series.data. But the types do not allow it.

Empty value:
'-' or null or undefined or NaN can be used to describe that a data item does not exist (ps:not exist does not means its value is 0).
For example, line chart can break when encounter an empty value, and scatter chart do not display graphic elements for empty values.

This is mostly a FYI PR, haven't done any dues on how this will affect the rest of the types. Tests etc.

@echarts-bot
Copy link

echarts-bot bot commented Sep 13, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

@github-actions
Copy link
Contributor

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19111@33b437d

@Ovilia Ovilia merged commit a51f449 into apache:master Sep 26, 2023
2 checks passed
@echarts-bot
Copy link

echarts-bot bot commented Sep 26, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia added this to the 5.5.0 milestone Sep 26, 2023
@plainheart plainheart changed the title Add nullables to OptionDataValue fix(type): allow nullable value for OptionDataValue Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants