Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(line): fix line may cross in time axis when animation is enabled #18960

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix(line): fix line may cross in time axis when animation is enabled #18960

merged 1 commit into from
Nov 30, 2023

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Aug 4, 2023 •
edited

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix a bug brought by #18032, it may result in abnormal line animation.

Fixed issues

Reproduction Link

Before

After

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Aug 4, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart added this to the 5.5.0 milestone Aug 4, 2023
@plainheart plainheart requested a review from pissang August 4, 2023 05:55
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-18960@7d02d5c

@plainheart plainheart changed the title fix(line): fix line may cross when animation is enabled fix(line): fix line may cross in time axis when animation is enabled Aug 4, 2023
This was referenced Aug 6, 2023
Open
Open
@plainheart plainheart requested review from pissang and removed request for pissang October 6, 2023 07:09
@plainheart plainheart requested review from Ovilia and removed request for pissang November 17, 2023 03:46
@Ovilia Ovilia merged commit 80525ed into master Nov 30, 2023
2 checks passed
@echarts-bot ECharts Bot
Copy link

echarts-bot bot commented Nov 30, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@Ovilia Ovilia deleted the fix/line-animation branch November 30, 2023 07:12
@plainheart plainheart mentioned this pull request Dec 9, 2023
Closed
@plainheart plainheart mentioned this pull request Feb 14, 2024
Closed
@X-oss-byte X-oss-byte mentioned this pull request May 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ovilia Ovilia Ovilia approved these changes

@ZachLegros ZachLegros ZachLegros approved these changes

Assignees
No one assigned
Labels
PR: author is committer PR: doc unchanged size/XS
Projects
None yet
Milestone
5.5.0
3 participants
@plainheart @Ovilia @ZachLegros