Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update shelljs to 0.8.5 #115

Merged
merged 1 commit into from
Jan 13, 2023
Merged

fix: update shelljs to 0.8.5 #115

merged 1 commit into from
Jan 13, 2023

Conversation

jcesarmobile
Copy link
Member

Update the shelljs dependency to 0.8.5 as previous versions are vulnerable

There is a behavior change in shelljs that requires the project_path to exist before doing the first recursive copy or if not it will copy the content of the cordova directory instead of creating a cordova directory with all the content as 0.5.3 did. That's why there is one line addition.

closes #105
closes #108

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Merging #115 (4805d13) into master (2218451) will increase coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   93.54%   93.75%   +0.20%     
==========================================
  Files           2        2              
  Lines          31       32       +1     
==========================================
+ Hits           29       30       +1     
  Misses          2        2              
Impacted Files Coverage Δ
bin/lib/create.js 93.33% <100.00%> (+0.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jcesarmobile jcesarmobile merged commit 4fe7e97 into master Jan 13, 2023
@jcesarmobile jcesarmobile deleted the update-shelljs branch January 13, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump shelljs ≥ 0.8.5
3 participants