Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.1.4 patch updates #573

Merged
merged 4 commits into from
Nov 22, 2018
Merged

7.1.4 patch updates #573

merged 4 commits into from
Nov 22, 2018

Conversation

brodybits
Copy link
Contributor

@brodybits brodybits commented Nov 22, 2018

If approved, I would like to merge later today and make a 7.1.4 patch release.

Christopher J. Brody and others added 4 commits November 22, 2018 09:49
…e#567)

We have this of the package name. It only outputs that the current one
is bad, not what the current one actually is. Added an output of the
current one to the error.
(subdirectories) such as "appco", with unit tests to verify

Needed for @katzer plugins that use de/appplant subdirectory,
for example:
* cordova-plugin-local-notifications
* cordova-plugin-badge
* cordova-plugin-background-mode

Also needed for cordova-plugin-inappbrowser

Co-authored-by: Christopher J. Brody <chris.brody@gmail.com>
Co-authored-by: Julio César <jcesarmobile@gmail.com>
Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #573 into 7.1.x will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##            7.1.x     #573   +/-   ##
=======================================
  Coverage   44.63%   44.63%           
=======================================
  Files          17       17           
  Lines        1705     1705           
  Branches      316      316           
=======================================
  Hits          761      761           
  Misses        944      944
Impacted Files Coverage Δ
bin/templates/cordova/lib/pluginHandlers.js 87.97% <100%> (ø) ⬆️
bin/lib/create.js 54.69% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afdffe4...8586d4a. Read the comment docs.

@janpio
Copy link
Member

janpio commented Nov 22, 2018

Sure that you want to include the dep updates?

Besides that: let's get this out as fast as possible.

@guyromb
Copy link

guyromb commented Nov 22, 2018

Can you please release it? Thanks!

@dpogue
Copy link
Member

dpogue commented Nov 22, 2018

Can you please release it?

We're trying to run some additional tests to catch any other potential issues, and figuring out whether we can do an accelerated release. A typical release takes at least 2 days due to a mandatory 48-hour voting period on the mailing list (as per Apache Software Foundation rules).

@brodybits
Copy link
Contributor Author

brodybits commented Nov 22, 2018 via email

@brodybits brodybits merged commit b7643a3 into apache:7.1.x Nov 22, 2018
@brodybits brodybits deleted the 7.1.4-patch-updates branch November 22, 2018 19:46
@brodybits
Copy link
Contributor Author

I reverted 5a5f544 to remove "some other minor dependencies updates" from upcoming patch release, rationale is in 84cb08b. (I discovered had missed a duplicated dependency, further explanation is in 84cb08b.) I did the revert in a direct manner in order to unblock the 7.1.4 release. Note that neither the 5a5f544 updates nor the revert will show up in the master branch.

Also note that the android-versions@1.4.0 update was in its own commit, not reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants