Cordova project ignores build-extras after toolchain upgrade

[DavidWiesner]

After upgrade my project from cordova-android 6.4 to 7.1.2 my build-extras.gradle get not applied anymore. I checked the documentation for changes but there is still mentioned to place the build-extras.gradle file to platforms/android/.

When I place my build-extras.gradle file to platforms/android/app/ all work like expected.

[brodybits]

Please show exactly exactly what you did in plugin.xml for both 6.4 and 7.1.2. I think we will have to fix bin/templates/cordova/lib/pluginHandlers.js to resolve this issue without introducing a breaking change.

A major bonus is if you can show us a plugin we can use to test the solution.

[DavidWiesner]

In my case I did nothing with plugins. I just add a platforms/android/build-extras.gradle file manually adding some dependencies.

Steps for reproduce:

1. add a platforms/android/build-extras.gradle file with this content

ext.postBuildExtras = { println('### build-extras.gradle called ###') }

2. run cordova build android
3. no ### build-extras.gradle called ### was printed in the console

adding the same file to platforms/android/app/ will print the line

[brodybits]

That is because the Android project structure was changed in 7.0. I just raised apache/cordova-docs#905 to update the documentation.

[DavidWiesner]

I know the structure has changed. But why also change the location of the build-extras.gradle? All other configuration files e.g.: release-signing.properties are still referenced from the old location: platforms/android/

[brodybits]

I just pushed an update to PR #553 to check both locations.

[janpio]

But why also change the location of the build-extras.gradle?

That was probably overlooked when changing the project structure back in 7.x. You would have to go back to those commits where the other paths were handled and see if there maybe is a comment in the PR or commit message.

[DavidWiesner]

Here is one issue (CB-13615) reflecting the new structure and changing the paths accordingly. But this is only for the signing configurations.

[brodybits]

From the history it looks like the work was done in PR #389. It seems like they did try to preserve compatibility, but evidently it was not preserved 100%.

All other configuration files e.g.: release-signing.properties are still referenced from the old location: platforms/android/

I find that really interesting, just discovered that release-signing.properties is referenced by both bin/templates/project/app/build.gradle and bin/templates/project/legacy/build.gradle. I have no idea how or even if they would work together.

[brodybits]

Closing since PR #553 was merged. This should be fixed in upcoming 7.1.3 release.