Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14165 : (android) Fix for device still connecting issues #457

Merged
merged 1 commit into from
Jun 25, 2018

Conversation

gegenokitaro
Copy link
Contributor

@gegenokitaro gegenokitaro commented Jun 25, 2018

Platforms affected

Android (Emulator)

What does this PR do?

Add fix for 'device still connecting' problem when using android emulator

What testing has been done on this change?

launching cordova emulate android

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Add error message checking for device still connecting issues
@codecov-io
Copy link

Codecov Report

Merging #457 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
- Coverage   52.06%   52.03%   -0.04%     
==========================================
  Files          17       17              
  Lines        1694     1695       +1     
  Branches      311      312       +1     
==========================================
  Hits          882      882              
- Misses        812      813       +1
Impacted Files Coverage Δ
bin/templates/cordova/lib/emulator.js 48.46% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9750b5...8d49778. Read the comment docs.

@gegenokitaro gegenokitaro changed the title Fix for device still connecting issues CB-14165 : (android) Fix for device still connecting issues Jun 25, 2018
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raphinesse raphinesse merged commit 46a036e into apache:master Jun 25, 2018
@raphinesse
Copy link
Contributor

raphinesse commented Jun 25, 2018

Thank you very much for this fix! 🙇‍♂️

jcesarmobile pushed a commit to jcesarmobile/cordova-android that referenced this pull request Aug 2, 2018
Keep waiting for emulator when connection fails with "device still connecting" error
brodybits pushed a commit that referenced this pull request Aug 2, 2018
Keep waiting for emulator when connection fails with "device still connecting" error
@MatanYadaev

This comment has been minimized.

@mrfatstrat
Copy link

This fix doesn't seem to be included in the latest release 7.1.1 which I would expect since the fix was done Jun 25th and the release Jul 12th, any particular reason for this? I really need this one.

@janpio
Copy link
Member

janpio commented Aug 17, 2018

The release process of 7.1.1 was started Jun 19, 2018, which is a few days before this was merged into master.
The next release 7.1.2 whose preparation started Aug 2, 2018 by @brodybits will include this change.
(Yep, Cordova's release processes are a bit more complicated)

If you really need it, you can either install from master or the 7.1.x branch (where this was merged in preparation for 7.1.2)

@gegenokitaro gegenokitaro deleted the fix branch November 7, 2018 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants