Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSV-306] followup to fix deprecated method in user guide #325

Merged
merged 1 commit into from
May 1, 2023

Conversation

samabcde
Copy link
Contributor

@samabcde samabcde commented May 1, 2023

Follow up from comment #324 (review)

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

@codecov-commenter
Copy link

Codecov Report

Merging #325 (5b6cba0) into master (e0d3660) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #325   +/-   ##
=========================================
  Coverage     97.87%   97.87%           
  Complexity      549      549           
=========================================
  Files            11       11           
  Lines          1178     1178           
  Branches        204      204           
=========================================
  Hits           1153     1153           
  Misses           13       13           
  Partials         12       12           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

kinow added a commit that referenced this pull request May 1, 2023
@kinow kinow merged commit 5b6cba0 into apache:master May 1, 2023
6 checks passed
@kinow
Copy link
Member

kinow commented May 1, 2023

Merged, thanks!

@garydgregory
Copy link
Member

@kinow
Should this be mentioned in changes.xml?

@kinow
Copy link
Member

kinow commented May 1, 2023

@kinow Should this be mentioned in changes.xml?

Already done so. I re-used the entry for the issue CSV-306 you merged, adding this PR as it complements that other one. 2835005 ☝️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants