Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSV-306] replace deprecated method in user guide, update external link #324

Merged
merged 1 commit into from
Apr 30, 2023

Conversation

samabcde
Copy link
Contributor

@samabcde samabcde commented Apr 30, 2023

@codecov-commenter
Copy link

Codecov Report

Merging #324 (133d221) into master (5af74b9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #324   +/-   ##
=========================================
  Coverage     97.87%   97.87%           
  Complexity      549      549           
=========================================
  Files            11       11           
  Lines          1178     1178           
  Branches        204      204           
=========================================
  Hits           1153     1153           
  Misses           13       13           
  Partials         12       12           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you!

<li><a href="http://www.osjava.org/genjava/multiproject/gj-csv/">Genjava CSV</a></li>
</ul>
<p>In addition to the code from Netcetera (org.apache.commons.csv), Martin van den Bemt has added an additional writer API. </p>
<p>Other CSV implementations: </p>
<ul>
<li><a href="http://supercsv.sourceforge.net/">Super CSV</a></li>
<li><a href="https://super-csv.github.io/super-csv/index.html">Super CSV</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 checked the sourceforge page, and it's redirecting to this github.io one.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samabcde I was going to merge and close CSV-306, but I think this PR does not fix CSV-306?

I imported this branch into my IDE, and looked at src/site/xdoc/user-guide.xml, and looking at the example code I started searching for methods and opening to check for @deprecated tags.

This line is also using withHeader()

final CSVParser parser = new CSVParser(reader, CSVFormat.EXCEL.withHeader());

marked as deprecated

* @deprecated Use {@link Builder#setHeader(Class)}

Further down there's another one

Iterable&lt;CSVRecord&gt; records = CSVFormat.RFC4180.withHeader("ID", "CustomerNo", "Name").parse(in);

I can merge this one and leave the JIRA issue open. Or if you'd like this PR to resolve CSV-306, could you look at the rest of the user guide fixing deprecated calls? Up to you 🙂

Cheers
Bruno

@kinow
Copy link
Member

kinow commented Apr 30, 2023

Oh, and thanks for fixing the links and typos!

@garydgregory garydgregory merged commit ccfbdd0 into apache:master Apr 30, 2023
6 checks passed
@samabcde
Copy link
Contributor Author

samabcde commented May 1, 2023

@samabcde I was going to merge and close CSV-306, but I think this PR does not fix CSV-306?

I imported this branch into my IDE, and looked at src/site/xdoc/user-guide.xml, and looking at the example code I started searching for methods and opening to check for @deprecated tags.

This line is also using withHeader()

final CSVParser parser = new CSVParser(reader, CSVFormat.EXCEL.withHeader());

marked as deprecated

* @deprecated Use {@link Builder#setHeader(Class)}

Further down there's another one

Iterable&lt;CSVRecord&gt; records = CSVFormat.RFC4180.withHeader("ID", "CustomerNo", "Name").parse(in);

I can merge this one and leave the JIRA issue open. Or if you'd like this PR to resolve CSV-306, could you look at the rest of the user guide fixing deprecated calls? Up to you 🙂

Cheers Bruno

@kinow , thx for pointing out, let me fix that also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants