CODEC-312: Fix possible StringIndexOutOfBoundException thrown by MatchRatingApproachEncoder.encode() method #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @arthurscchan |
arthurscchan
force-pushed
the
CODEC-312-StringIndexOutOfBound
branch
from
b2d07dd
to
700dfb2
Compare
|
Hi, I have added the unit test. |
|
@arthurscchan |
garydgregory
requested changes
Nov 24, 2023
There was a problem hiding this comment.
@arthurscchan
See my comments, and also, comments in other PRs that apply here.
src/main/java/org/apache/commons/codec/language/MatchRatingApproachEncoder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/codec/language/MatchRatingApproachEncoder.java
Outdated
Show resolved
Hide resolved
garydgregory
requested changes
Nov 24, 2023
There was a problem hiding this comment.
Hello @arthurscchan
Please see my comments here and in other PRs that apply here.
src/main/java/org/apache/commons/codec/language/MatchRatingApproachEncoder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/codec/language/MatchRatingApproachEncoder.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/commons/codec/language/MatchRatingApproachEncoderTest.java
Outdated
Show resolved
Hide resolved
arthurscchan
force-pushed
the
CODEC-312-StringIndexOutOfBound
branch
from
700dfb2
to
2124da2
Compare
arthurscchan
changed the title
arthurscchan
changed the title
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
arthurscchan
force-pushed
the
CODEC-312-StringIndexOutOfBound
branch
from
2124da2
to
2e0bfe5
Compare
garydgregory
requested changes
Nov 24, 2023
src/test/java/org/apache/commons/codec/language/MatchRatingApproachEncoderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/commons/codec/language/MatchRatingApproachEncoderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/commons/codec/language/MatchRatingApproachEncoderTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
arthurscchan
force-pushed
the
CODEC-312-StringIndexOutOfBound
branch
from
2e0bfe5
to
ce43dda
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #220 +/- ##
============================================
- Coverage 92.27% 92.22% -0.06%
- Complexity 1742 1745 +3
============================================
Files 67 67
Lines 4584 4591 +7
Branches 709 713 +4
============================================
+ Hits 4230 4234 +4
- Misses 242 243 +1
- Partials 112 114 +2 ☔ View full report in Codecov by Sentry. |
garydgregory
added a commit
that referenced
this pull request
Nov 25, 2023
…hRatingApproachEncoder.encode() method #220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a possible StringIndexOutOfBoundException in src/main/java/org/apache/commons/codec/language/MatchRatingApproachEncoder.java thrown by MatchRatingApproachEncoder.encode() method when the input string only contains punctuations or vowels.
This PR adds some conditional checking to ensure the string is not empty after each method call. If it is empty after any method call, it will simply return EMPTY and avoid continuing processing onto the next processing method.
We found this bug using fuzzing by way of OSS-Fuzz. It is reported at https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=64359.